Remove isort dependency, migrate to ruff equivalent#39411
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| "**/yaml_testing_test.py" = ["I"] | ||
| "**/bigquery_v2_client.py" = ["I"] | ||
| "**/bigquery_v2_messages.py" = ["I"] | ||
| "**/dataflow_v1b3_client.py" = ["I"] |
There was a problem hiding this comment.
this one is no more? consider trimming
There was a problem hiding this comment.
Cleaned up the ignores from the old generated clients, those were still in the ignore block in run_lint.sh
| ] | ||
| target-version = "py310" | ||
| src = ["apache_beam"] | ||
| line-length = 120 |
There was a problem hiding this comment.
this is not new change, is it? i noticed ruff didn't reformat lines longer than 80 characters recently.
There was a problem hiding this comment.
This is a carry-over from the fact that our isort configuration has a line length of 120 to allow for long imports on single lines but our typical formatting directive is an 80 character line. At the moment ruff doesn't allow per-linter line length settings (see astral-sh/ruff#3206) but we also don't use ruff for formatting, only the linting. yapf is still the tool we use to catch formatting mismatches (for now) so this shouldn't alter what we allow in the code base
2 participants
Removes the dependency on isort in Beam Python linting checks, configuring ruff's isort-equivalent checks to mirror the old settings. This 1) makes the linting workflow even faster and 2) makes import ordering issues automatically fixable by running
ruff check --fixwith no configuration mismatches between pyproject.toml and the run_lint.sh script.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.